zugferd-php icon indicating copy to clipboard operation
zugferd-php copied to clipboard
Published 3 months ago • verified publisher icon easybill

Ci improvements

Open guillaume-sainthillier opened this issue 1 year ago • 2 comments

Advantages to switch on laminas in CI:

  1. Tests are played with lower and higher dependencies packages versions
  2. Tests will be played with future php version (ex: 8.4, ...)
  3. Less code to write

A bug was spotted with jms/serializer starting from 3.16 which was not covered when keeping a composer.lock file

guillaume-sainthillier avatar Oct 21 '24 11:10 guillaume-sainthillier

@guillaume-sainthillier Thank you for opening the PR; the tooling looks very interesting! I noticed you mentioned encountering an issue with jms/serializer. The commit message here indicates that updating JMS addresses this.

Could you provide more details about the specific issue you encountered?

BolZer avatar Oct 25 '24 07:10 BolZer

Hello @BolZer, tests are simply not passing with jms/serializer 3.16. There is a bug they solved starting from 3.18 (https://github.com/schmittjoh/serializer/pull/1417)

guillaume-sainthillier avatar Oct 25 '24 11:10 guillaume-sainthillier