zugferd-php Minor update

improve code quality and CI workflows

Sep 28 '24 11:09 guillaume-sainthillier

@guillaume-sainthillier Thank your for opening the PR. However the PR is quite large and some of the changes are... quite drastic. Why change the CI pipeline? And an minor update pr with about 4k lines removed :)? Maybe we can shrink the PR and split it into more PRs which are easier to review. Could you open a discussion in this repository for the CI-Pipeline changes? What are the benefits and so. :)

Oct 19 '24 12:10 BolZer

Hello @BolZer, i've split this PR into 2 more by adding #65 and #66. Will rebase this branch once you decide to merge them (or not).

Thanks, Guillaume

Oct 21 '24 11:10 guillaume-sainthillier

Hello @BolZer, i've split this PR into 2 more by adding #65 and #66. Will rebase this branch once you decide to merge them (or not).

Thanks, Guillaume

Thanks @guillaume-sainthillier. That's much better to understand. We'll continue the discussion in the remaining PRs. The PR with the PHPStan modifications is already merged. Thank you :)

Oct 25 '24 06:10 BolZer

@guillaume-sainthillier Thank you for your work on this. Several updates to the library have made this PR outdated and likely unnecessary now. Thanks again for your contribution.

Oct 14 '25 13:10 BolZer

@BolZer okay no pb, what about the #66 ? Still actual to test on minor and major package versions?

Oct 14 '25 18:10 guillaume-sainthillier