earth-analytics-python-env icon indicating copy to clipboard operation
earth-analytics-python-env copied to clipboard
verified publisher icon earthlab

Upgrade to 3.10

Open eculler opened this issue 2 years ago • 2 comments

Description

Please include a summary of the change and which issue is fixed. Be sure to reference the ISSUE that this PR addresses which should have been approved by an earthpy maintainer.

Fixes #96 and #94

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Built a docker container with the new environment, see https://hub.docker.com/repository/docker/earthlab/earth-analytics-python-env/general
  • Docker container successfully runs using key packages (rioxarray, geopandas) in GitHub Actions ubuntu-latest, and GitHub Codespaces

Checklist:

  • [ ] I have already submitted an issue and i was invited to submit a pr by an earthdatascience.org maintainer
  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] I have checked my code and corrected any misspellings

eculler avatar May 31 '23 17:05 eculler

The merge conflicts come from an updated Action. The action in questions was based on a similar action used by Cyverse for their geospatial containers (i.e. it activates the conda environment robustly and installs some jupyterlab extensions.

eculler avatar May 31 '23 17:05 eculler

Note the following potential problems, which I have not been able to reproduce:

  • I've gotten reports of the rasterstats package failing with a message about an incompatible version of numpy.
  • I've eliminated the pins on nbconvert and jupyter_contrib, even though the coroutine error that inspires those has not been fixed in the jupyter notebook extension (nor do there seem to be plans to do so). Please use jupyter lab instead, which runs nbgrader commands without incident.

eculler avatar May 31 '23 17:05 eculler