streamdeck-clockify icon indicating copy to clipboard operation
streamdeck-clockify copied to clipboard

Multiple timers on the same project with different tasks show the same timer

Open HughMacdonald opened this issue 1 year ago • 1 comments

If you have multiple tasks in Clockify in a project, and have separate StreamDeck buttons linked to each one, when you start a timer, all of the buttons show the same timer.

Looking at the code (https://github.com/eXpl0it3r/streamdeck-clockify/blob/b98db7b354131463ba2c166c6a52813f63b115cc/Clockify/ClockifyContext.cs#L141), it doesn't appear to use the task name when identifying the timer that is currently running.

HughMacdonald avatar Jun 19 '24 12:06 HughMacdonald

Good point, if we do have the task set, we should also filter for it.
Maybe that was broken in the last refactoring.

eXpl0it3r avatar Jun 19 '24 12:06 eXpl0it3r

I've now hit the point where I actually need to be able to do this - I'd forgotten about this bug. I'm going to see if I can fix it today

HughMacdonald avatar Nov 19 '24 10:11 HughMacdonald

@HughMacdonald can you give this dev version a try?

https://github.com/eXpl0it3r/streamdeck-clockify/actions/runs/11956056708/artifacts/2219402352

eXpl0it3r avatar Nov 21 '24 15:11 eXpl0it3r

That worked for me

That'll be a good workaround for now if I don't figure out the CLI to do the build locally

HughMacdonald avatar Nov 21 '24 16:11 HughMacdonald

I thought you were just sending that to test if the build worked, but it's actually fixed up the task filtering issue too - thanks for that - very helpful

HughMacdonald avatar Nov 21 '24 17:11 HughMacdonald

Woops, yeah linked the wrong issue in the PR 😅

Fixed in #27

Sorry for not working on this sooner. I kind of forgot and been focused on other projects 😓

eXpl0it3r avatar Nov 21 '24 17:11 eXpl0it3r