particlespy icon indicating copy to clipboard operation
particlespy copied to clipboard

pyqt as optional dependency

Open ericpre opened this issue 4 years ago • 5 comments

qt is a one of the largest dependencies (100 Mo) and can't be used remotely (cloud or cluster). Making this dependency optional would allow to use smaller docker image, etc.

ericpre avatar Apr 22 '21 20:04 ericpre

This would make sense. I might make it so that the default is to include pyqt, but have the option to not include it for docker images etc.

TomSlater avatar Apr 23 '21 12:04 TomSlater

This would make sense. I might make it so that the default is to include pyqt, but have the option to not include it for docker images etc.

Is it possible with pip?

ericpre avatar Apr 23 '21 12:04 ericpre

This would make sense. I might make it so that the default is to include pyqt, but have the option to not include it for docker images etc.

Is it possible with pip?

I'm not sure it is, based on this thread. I could just strip out pyqt as a dependency and include its installation in the standard installation instructions.

TomSlater avatar Apr 23 '21 12:04 TomSlater

Maybe it would make most sense to just have pyqt as an optional dependency but use this in the standard instructions.

TomSlater avatar Apr 23 '21 12:04 TomSlater

Yes, this is usually how it is done.

On a similar topic, it may be worth considering using qtpy, to allow using pyside.

ericpre avatar Apr 23 '21 16:04 ericpre