particlespy icon indicating copy to clipboard operation
particlespy copied to clipboard

Create boundary_analysis.py

Open YichiWang opened this issue 5 years ago • 3 comments

This is a standalone script to perform particle boundary analysis such as boundary curvature and find boundary pixels in clockwise sequence.

Tom I am not sure how do you want to integrate this into ParticleSpy. One of your opened issue you mentioned could make particlespy to allow plug-in additions. This script can also be implemented to scikit-image in the future I think.

YichiWang avatar Aug 04 '20 01:08 YichiWang

Codecov Report

Merging #52 into master will decrease coverage by 12.08%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #52       +/-   ##
===========================================
- Coverage   81.48%   69.39%   -12.09%     
===========================================
  Files          13       14        +1     
  Lines         821      964      +143     
===========================================
  Hits          669      669               
- Misses        152      295      +143     
Impacted Files Coverage Δ
ParticleSpy/boundary_analysis.py 0.00% <0.00%> (ø)

codecov[bot] avatar Aug 04 '20 01:08 codecov[bot]

I think this would be good to leave as a utility function that can be run on individual particles. i.e. it isn't run when doing ParticleAnalysis. It would be good to have a function that could be run on one Particle and one that could be run on a Particle_list.

What do you think the output for a user should be? Maybe a min, max and average curvature to be added to particle properties? Plus the option to plot the curvature of particles(s) when running the analysis?

TomSlater avatar Aug 04 '20 10:08 TomSlater

I think this would be good to leave as a utility function that can be run on individual particles. i.e. it isn't run when doing ParticleAnalysis. It would be good to have a function that could be run on one Particle and one that could be run on a Particle_list.

What do you think the output for a user should be? Maybe a min, max and average curvature to be added to particle properties? Plus the option to plot the curvature of particles(s) when running the analysis?

Yes I agree to all above you suggested.

YichiWang avatar Aug 05 '20 02:08 YichiWang