HomeStore icon indicating copy to clipboard operation
HomeStore copied to clipboard

nuraft param with_log_sync_stopping_gap causes new follower to stop resync

Open sanebay opened this issue 1 year ago • 2 comments

https://github.com/eBay/HomeStore/pull/546/files Uploading not-working.tar.gz…

sanebay avatar Sep 24 '24 19:09 sanebay

@sanebay logs are not downloadable

xiaoxichen avatar Sep 25 '24 23:09 xiaoxichen

For some reason, its stuck at uploading. I will paste in the internal channel.

sanebay avatar Sep 25 '24 23:09 sanebay

This issue is mostly due to nuraft will use log pack to sync the new follower till the new follower catch up to log_sync_stopping_gap, however , in HomeStore we localize the journal entries , there is no callback available in log pack path, the log from leader will be added as-is to the HomeStore which is obviously wrong.

The #546 make log_sync_stopping_gap to default 99999 which is larger than any of the written IO counts in our UTs that avoid the log pack sync.

#587 set it to max_int32 as well as enable the learner feature, with the learner feature new member will not go through log pack in any case.

xiaoxichen avatar Nov 22 '24 22:11 xiaoxichen