HomeStore icon indicating copy to clipboard operation
HomeStore copied to clipboard

Track timestamp of each state in repl_dev_ctx.

Open xiaoxichen opened this issue 1 year ago • 2 comments

With this we can easily get time diff of each given state, avoid doing the calculation/analysis from grep of logs.

xiaoxichen avatar Aug 20 '24 02:08 xiaoxichen

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.22%. Comparing base (1a0cef8) to head (05e7165). Report is 56 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/replication/repl_dev/common.cpp 50.00% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #514       +/-   ##
===========================================
+ Coverage   56.51%   68.22%   +11.71%     
===========================================
  Files         108      109        +1     
  Lines       10300    10439      +139     
  Branches     1402     1400        -2     
===========================================
+ Hits         5821     7122     +1301     
+ Misses       3894     2642     -1252     
- Partials      585      675       +90     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 20 '24 02:08 codecov-commenter

Do we still want this change? I'm cleaning stale/idle PRs.

zhiteng avatar Sep 28 '24 02:09 zhiteng