HomeStore icon indicating copy to clipboard operation
HomeStore copied to clipboard

Improve test_raft_repl_dev UT

Open xiaoxichen opened this issue 1 year ago • 4 comments

majar changes:

  1. fix device list
  2. when leader switches , new leader will continue to write in write_on_leader.
  3. logging improvement, print out ms/us for timestamp.

Other than UT

implement rollback for statemachine.

xiaoxichen avatar Jul 16 '24 17:07 xiaoxichen

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.16%. Comparing base (1a0cef8) to head (aa77d71). Report is 55 commits behind head on master.

Files with missing lines Patch % Lines
...rc/lib/replication/repl_dev/raft_state_machine.cpp 0.00% 7 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #464       +/-   ##
===========================================
+ Coverage   56.51%   68.16%   +11.64%     
===========================================
  Files         108      109        +1     
  Lines       10300    10438      +138     
  Branches     1402     1400        -2     
===========================================
+ Hits         5821     7115     +1294     
+ Misses       3894     2645     -1249     
- Partials      585      678       +93     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 02 '24 07:09 codecov-commenter

I believe this PR will be very helpful for raft_repl_dev UT. pls proceed and finish this PR, thanks

JacksonYao287 avatar Sep 11 '24 15:09 JacksonYao287

This PR has been idle for one month. Do we still want to merge this?

zhiteng avatar Sep 28 '24 02:09 zhiteng

This PR has been idle for one month. Do we still want to merge this?

this PR is very helpful to make repl_dev unit test stable in github CI. after this , we can enable Leader_Restart which stucks intermittently.

@xiaoxichen pls go ahead and complete this PR when you get cycle.

JacksonYao287 avatar Sep 28 '24 11:09 JacksonYao287