HomeStore
HomeStore copied to clipboard
Fixed the number of chunks issue
At present the number of chunk info slots pre created is incorrectly did not convert number of bytes to bits. Fixed that issue.
Is that better to hornor the requested num_bits instead of honor the serialize size?
we are now:
- round num_chunks to 4K boundary and convert to byte, to get
bit_map_sizebitmap_size - serialization_taxthen convert to bit, to the Bitset size.which is a bit disconnect between the original requests (num_chunks) and final bitmap available bits.
Considering doing
m_chunk_info_slots = std::make_unique< sisl::Bitset >(hs_super_blk::max_chunks_in_pdev(m_dev_info));the bitmap_mem is align to align_size (512) not 4K but it should be fine right
Yes I adjusted the code accordingly @xiaoxichen please take a look.
@raakella1 I see several commits in the master branch about this pr. pls do squash merge next , thx!