dzcode.io icon indicating copy to clipboard operation
dzcode.io copied to clipboard

Migration to `@dzcode.io/ui-mobile`: check list

Open omdxp opened this issue 3 years ago • 3 comments

Description This milestone is dedicated to create a @dzcode.io/ui-mobile package that contains common components in the mobile codebase.

Check List

  • [x] #496
  • [x] #494
  • [x] #499
  • [x] #502
  • [x] #505
  • [x] #508
  • [ ] #511
  • [ ] add jsdoc to @dzcode.io/ui-mobile

omdxp avatar Sep 22 '22 15:09 omdxp

I think we should also migrate other components, the ones from:

  • @react-native-community/masked-view
  • @react-navigation/bottom-tabs
  • @react-navigation/drawer
  • react-native-markdown-display
  • react-native-paper
  • essentially, any Visual components from ./mobile has to be imported from @dzcode.io/ui-mobile

ZibanPirate avatar Sep 25 '22 12:09 ZibanPirate

So you want a wrapper for each one of these packages ?

omdxp avatar Sep 25 '22 12:09 omdxp

ideally yes, a wrapper like I'm doing in src/v2/divider, with a consistent props interface, or, simply just an export from the package so we would import from our internal package even though it's literally just an export redirection.

ZibanPirate avatar Sep 25 '22 13:09 ZibanPirate