Boudewijn Vahrmeijer comments

Results 65 comments of


                                            Boudewijn Vahrmeijer

New feature for client side prevention of unwanted multiple form submissions

perhabs its even better to make this a vanilla script. Not every app uses jquery.

New feature for client side prevention of unwanted multiple form submissions

just experienced that a jQuery version is also not to be preferable in high traffic websites in which jQuery is left out.

Activedataprovider set limit inside of query with union but should outside

> It's a specific use case. Not if you look at the topic @klimov-paul supplied. We should develop a solution that matches the expected result of the issue introduction.

Activedataprovider set limit inside of query with union but should outside

agree, thats intuitive

Ignore unnecessary joinWiths

by their $alias as these also have to be unique in the DBMS.

Idea: avoid double declare link and type of relation if used via()

can you elaborate on your usecase and why it is necessary compared to `BaseActiveRecord::createRelationQuery()`

ActiveRecord::__get priority

> Perhaps, but it seems it was some reason behind the current implementation - I just can not remember, which exactly. Need to be careful here. Perhabs consistency between $_oldAttributes...

LinkPager loose main css class before is defined

I agree this to be cumbersome. It's better to set "default array values" in the init() method.

Should ListView/GridView return to first page when sort changes

staying on the same page (depth) is not really logical, as this is related to another sort criterium. This is room for improvement. @Sammaye, @Faryshta , do you have ideas...

Query limit not working with pager enabled.

ran into this one yesterday. It was unexpected behavior.