elixir-auth-google icon indicating copy to clipboard operation
elixir-auth-google copied to clipboard

runtime environment variables support

Open fuchsberger opened this issue 3 years ago โ€ข 3 comments

Fantastic package, thanks a lot!

Would it be possible to support fetching environment variables at runtime via config/runtime.exs? Thus replacing Application.get_env/2 with Application.fetch_env/2.

fuchsberger avatar Jan 26 '23 13:01 fuchsberger

Hi Professor @fuchsberger ๐Ÿ‘‹ ๐Ÿ˜‰ Thanks for the feedback + feature request! ๐Ÿ™Œ Totally. Application.fetch_env/2 makes perfect sense. You've been invited to the @dwyl org: https://github.com/dwyl And have write access to this repo: https://github.com/dwyl/elixir-auth-google/invitations

So if you have time to implement with tests/docs please go for it. ๐Ÿ‘Œ (Create a branch and Pull Request) Otherwise it will stay on our "backlog" until one of the core team can get to it. โณ

nelsonic avatar Jan 26 '23 14:01 nelsonic

i would try but its unlikely I get around to it for weeks and might be a little out of my league. thanks for the feedback!

fuchsberger avatar Jan 26 '23 15:01 fuchsberger

@fuchsberger fair enough. ๐Ÿ‘Œ It should just be a case statement to check for the presence of the env at runtime. ๐Ÿ’ญ @SimonLab might be able to look at it next week. โณ Thanks again for opening the issue. ๐Ÿ‘

nelsonic avatar Jan 26 '23 16:01 nelsonic