zxcvbn-python icon indicating copy to clipboard operation
zxcvbn-python copied to clipboard

drop support for python 2 and add some typing

Open fuhrysteve opened this issue 5 years ago • 2 comments

Not sure if you're open to dropping python 2 support, but I thought I'd test the waters!

Nothing too exciting, just adding typing on the user-facing zxcvbn() function and in a couple other super easy places, if only to make sure mypy & github actions are actually working.

Please note that this fully breaks backward compatibility with python 3.5 or lower, as it uses features introduced in python 3.6.

fuhrysteve avatar Feb 04 '21 22:02 fuhrysteve

Given it's been EOL for a year now it's probably time. I would just want to bump a major version.

dwolfhub avatar Feb 05 '21 15:02 dwolfhub

Bumped the major version number to 5 and updated the docs!

fuhrysteve avatar Feb 05 '21 16:02 fuhrysteve