chrome-extension-cli icon indicating copy to clipboard operation
chrome-extension-cli copied to clipboard

Add --webextension option to command line

Open Andras-Simon opened this issue 6 years ago • 8 comments

The --webextension option will automatically add webextension-polyfill to your extension by default as discussed in #1

Please don't merge this PR yet.

Andras-Simon avatar Oct 19 '19 07:10 Andras-Simon

As most of the users would want their extension to work cross-browser, I was thinking of keeping WebExtension as a built-in support and not enable it through an option from command line.

What do you think?

dutiyesh avatar Oct 19 '19 07:10 dutiyesh

Good point. However if WebExtensions will be enabled by default that will break backward compatibility (eg. if someone already used the cli to generate a project and uses it again the new version the outputs will differ). It might be not a big deal, just a thing to consider.

Andras-Simon avatar Oct 20 '19 19:10 Andras-Simon

I don't think this change will break existing code since we are adding a new feature and not replacing.

And while releasing it we are going to mention it in our changelog file, so that user can know the version from which WebExtensions support was introduced.

dutiyesh avatar Oct 22 '19 18:10 dutiyesh

Alright @dutiyesh ! Should I then change it to something like --no-webextension in case somebody wants to build an extension without Webextension support?

Andras-Simon avatar Oct 22 '19 18:10 Andras-Simon

How about --no-cross-browser? It is a generic term and hides the implementation details (WebExtension API) behind disabling cross-browser support.

dutiyesh avatar Oct 23 '19 04:10 dutiyesh

@dutiyesh I like it! Lets go with --no-cross-browser

Andras-Simon avatar Oct 23 '19 09:10 Andras-Simon

@dutiyesh I think the PR is ready, I will test the generated outputs tomorrow. In the meantime, please have a look at it

Andras-Simon avatar Oct 29 '19 13:10 Andras-Simon

Hi! Any news on this? Thanks!

martinmanzo avatar Mar 16 '22 21:03 martinmanzo