metasearch icon indicating copy to clipboard operation
metasearch copied to clipboard
verified publisher icon duolingo

add spinner and sidebar toggle

Open d-rk opened this issue 4 years ago • 2 comments

Hi

I hope you don't mind another PR from me :cold_sweat:

This PR introduces the following:

  • the sidebar is hidden by default (needed for the spinner)
  • while search for an engine is running a spinner is shown
  • a click on the sidebar first focuses the engine results. a second click collapses the engine results and a third one expands them again
  • links in search results are opened on a new page

d-rk avatar Jan 24 '22 10:01 d-rk

Could you please post some screenshots? I'm having trouble getting the spinner to appear :thinking:

Also I'd prefer to follow standard UI patterns (seen in other search websites like Google) by letting the user decide whether they want to open result links in new tabs (e.g. via middle click or ctrl+click) rather than deciding for them

artnc avatar Jan 24 '22 20:01 artnc

Could you please post some screenshots? I'm having trouble getting the spinner to appear :thinking:

I tested it again in Firefox and Chrome. Works on my machine :) spinner

Also I'd prefer to follow standard UI patterns (seen in other search websites like Google) by letting the user decide whether they want to open result links in new tabs (e.g. via middle click or ctrl+click) rather than deciding for them

Thats a valid point. I reverted the changed link open behavior

d-rk avatar Jan 25 '22 07:01 d-rk