react-esi icon indicating copy to clipboard operation
react-esi copied to clipboard

Feat: migrate to Github Actions

Open Fabious opened this issue 4 years ago • 5 comments

Related: #31

Fabious avatar Nov 10 '21 07:11 Fabious

Actions preview:

https://github.com/Fabious/react-esi/actions

Fabious avatar Nov 10 '21 08:11 Fabious

We should be able to use the coveralls GitHub Action to upload the coverage.

dunglas avatar Nov 10 '21 08:11 dunglas

Ho ok, got an error with coveralls as seen here : https://github.com/Fabious/react-esi/runs/4162385127?check_suite_focus=true

Same error on local (main branch), will try to find a solution

edit: Found the solution i guess: https://github.com/lemurheavy/coveralls-public/issues/632

Fabious avatar Nov 10 '21 08:11 Fabious

ok fixed coveralls: https://github.com/Fabious/react-esi/runs/4163101844?check_suite_focus=true

Can you check if it's all good? After that the last thing is to automate publishing to npm?

Fabious avatar Nov 10 '21 09:11 Fabious

I added a release action, for this one i'm not sure how to test it and how we should implement the said release If you have the time to look =]

Fabious avatar Nov 10 '21 14:11 Fabious

As this PR has gone stale (2021 😵‍), i leave this here as a CLI helper exists and i think it will help

https://github.com/semantic-release/semantic-release/blob/master/docs/usage/getting-started.md#getting-started

Maybe I'll look into it and this PR when i have a bit of time!

Fabious avatar Jun 14 '23 15:06 Fabious

I have simplified this PR : I initiated only one but important Action for testing the app on a pull request

Will make an other PR for the release phase (aka publishing on npm)

Fabious avatar Jun 15 '23 15:06 Fabious

Thank you Fabien!

dunglas avatar Jun 16 '23 08:06 dunglas