phpfm icon indicating copy to clipboard operation
phpfm copied to clipboard

Updating is_binary function

Open ValentinAUCLERC opened this issue 10 months ago • 1 comments

Resolve issue #70

The current function check if "text" or "x-empty" is in the mimetype to determine if it's a binary or not. We have some files flagged as application/javascript that are considered as binary even if they are not.

This PR correct it by relying on file encoding. The flaw is that it depends on mbstring (might not be installed everywhere) so the legacy function is still here for fallback.

ValentinAUCLERC avatar Mar 18 '25 14:03 ValentinAUCLERC

Thanks, i will test and merge.

dulldusk avatar May 18 '25 20:05 dulldusk