Supporting error messages

[dulikvor]

The user should be able to indicate errors by using annotations. un handled exceptions should produce error annotations.

[codefromthecrypt]

just reminder.. for us, if the tag name is "error" it will make the span red in the UI and count as error in the dependency graph

if it is a timestamp annotation and substring "error" it will make the span yellow in the UI, but no effect in the dependency graph

[dulikvor]

Thank you for the correction, will make sure the stack trace of an un handled exception is being propagated as a tag. and will provide the user the capability to report both in general.

[codefromthecrypt]

usually we avoid stack trace as can be big and prefer error message. often log correlation can jump to stack trace.

On Mon, May 20, 2019, 4:22 PM Dudi Likvornik [email protected] wrote:

Thanks for the correction, will make sure the stack trace of an un handled exception is being propagated as tag. and will provide the user the capability to report both in general.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Dudi119/cppKin/issues/83?email_source=notifications&email_token=AAAPVV7INXY3UXNBOX2BXCTPWKXZZA5CNFSM4HN4OHIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVY7TTY#issuecomment-494008783, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPVV432FP4QF5X5GD6GJLPWKXZZANCNFSM4HN4OHIA .