iOS
iOS copied to clipboard
DuckPlayer updates and rewrites
Task/Issue URL: https://app.asana.com/0/0/1208563377656003/f Tech Design URL: CC:
Description:
DuckPlayer Updates
- Updates and streamlines DuckPlayer logic to be based on URL changes exclusively, which removes all
decidePolicylogic and more stuff fromTabViewController🎉 - Adds New Tests to cover for more navigation scenarios
- Reviews and fixes DuckPlayer Pixel logic
- Removes DuckPlayer Launch Experiment
Open In New tab Updates
- Adds Open in New Tab Settings and pixel placeholders
Steps to test this PR:
Unit tests cover base DuckPlayer navigation scenarios, but you can:
- Set DuckPlayer to Always Ask
- Smoke Test links from SERP and YouTube Website
- Set DuckPlayer to 'Always'
- Smoke Test links from SERP and YouTube Website
Note: No new tab functionality is present in this PR.
| Warnings | |
|---|---|
| :warning: | PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible. |
| Messages | |
|---|---|
| :book: |
You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information. |
Generated by :no_entry_sign: dangerJS against 419a253f7bc833cf058d7988466cd0b2c1154668
Code LGTM, but there's an issue I can reproduce on device, details here