iOS icon indicating copy to clipboard operation
iOS copied to clipboard

DuckPlayer updates and rewrites

Open afterxleep opened this issue 1 year ago • 2 comments

Task/Issue URL: https://app.asana.com/0/0/1208563377656003/f Tech Design URL: CC:

Description:

DuckPlayer Updates

  • Updates and streamlines DuckPlayer logic to be based on URL changes exclusively, which removes all decidePolicy logic and more stuff from TabViewController 🎉
  • Adds New Tests to cover for more navigation scenarios
  • Reviews and fixes DuckPlayer Pixel logic
  • Removes DuckPlayer Launch Experiment

Open In New tab Updates

  • Adds Open in New Tab Settings and pixel placeholders

Steps to test this PR:

Unit tests cover base DuckPlayer navigation scenarios, but you can:

  1. Set DuckPlayer to Always Ask
  2. Smoke Test links from SERP and YouTube Website
  3. Set DuckPlayer to 'Always'
  4. Smoke Test links from SERP and YouTube Website

Note: No new tab functionality is present in this PR.

afterxleep avatar Oct 18 '24 16:10 afterxleep

Warnings
:warning: PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
:book:

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by :no_entry_sign: dangerJS against 419a253f7bc833cf058d7988466cd0b2c1154668

github-actions[bot] avatar Oct 18 '24 17:10 github-actions[bot]

Code LGTM, but there's an issue I can reproduce on device, details here

Bunn avatar Oct 21 '24 19:10 Bunn