Android icon indicating copy to clipboard operation
Android copied to clipboard
verified publisher icon duckduckgo

Introduce backup rules to exclude backups

Open CDRussell opened this issue 1 year ago • 1 comments

Task/Issue URL: https://app.asana.com/0/0/1206667832334038/f

Description

Device backups are mostly disabled except for one instance where device-to-device backups are allowed. I've only noticed it happening for recent Samsung devices (specifically, the Samsung S24) but might be the same for others. For these devices:

  • they ignore appBackup="false" (which might be reasonable, given it's deprecated)
  • they do a device-to-device back (e.g., as part of the new device setup wizard where you can copy from your old phone)
  • this leaves the app working except for the secure functions (Autofill, Email Protection, Sync) which indicate that the "device is not supported". The reason for this is that encrypted data has been migrated between the devices but the decryption key was not, leaving those secure functions broken.

This PR disables those device-to-device backups entirely so the app can't be left in a broken state. There are two different mechanisms depending on whether the app is running on an Android 13 or newer device vs Android 12 or older.

Separate to this PR, I will pick up the conversation on backups more generally (whether to embrace more, whether to leave disabled etc...).

Steps to test this PR

Testing is a little fiddly, so happy to video chat our way through the review. ☎️

Android 13 / Android 14

  • [ ] Install our app on Android 13 / 14
  • [ ] Go through onboarding to reach new tab page
  • [ ] Run test script to trigger a device-to-device backup
  • [ ] It should fail, meaning the app won't be removed from the device. re-launch the app and everything will be as it was.

Android 12

  • [ ] Same as before

Optional testing steps (Transferring an individual app between two devices using Samsung Smart Switch)

  • [ ] Install Samsung Smart Switch on both devices (doesn't need to be a Samsung)
  • [ ] Install our app on device A, launch it and get through onboarding
  • [ ] Use Smart Switch to transfer that app to device B
  • [ ] Verify on device B that the app either starts as a fresh launch and shows onboarding, or that it doesnt' transfer

CDRussell avatar Feb 22 '24 17:02 CDRussell

  • #4204 Graphite 👈
  • develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on Graphite Graphite

CDRussell avatar Feb 22 '24 17:02 CDRussell