python-dts-calibration icon indicating copy to clipboard operation
python-dts-calibration copied to clipboard

IO AP sensing

Open davechris opened this issue 1 year ago • 1 comments

added code to io/apsensing.py to read both .xml and .tra files the code checks whether a .tra file with identical timestamp exists in .xml directory. If yes it is used to:

  • import t_by_dts, log_ratio, loss
  • pt100 data (if it exists in file)

This was a quick implementation. It was the first time I used XVector. I did not have the time to see weather it is efficient like this, but it works robustly. I don't know if the code should be added to the package, like this. But if we add it to a branch, AP sensing users would be able to get it and maybe to work it out nicely.

davechris avatar Apr 26 '24 13:04 davechris

Hi, thanks for contributing! The last weeks have been a bit hectic so I did not have time to look at this.

Nice that you have added these files and add proper support for AP Sensing files. This is a continuation of #218 right? If so, you can close that one.

Some tests for the old AP sensing data were already in the test suite https://github.com/dtscalibration/python-dts-calibration/blob/main/tests/test_datastore.py#L455 could you add some unit tests that use the new data and modified code?

Could you also update the changelog?

BSchilperoort avatar May 14 '24 14:05 BSchilperoort

I guess I cannot add my new commits to this pull request. So I'll start a new one and I'll close this one soon

davechris avatar Aug 30 '24 09:08 davechris