David Taylor
David Taylor
TFTR! bors r+
For the backport criteria, same argument made on https://github.com/cockroachdb/cockroach/pull/119563#issuecomment-1960635701 applies here.
For the backport criteria, same argument made on https://github.com/cockroachdb/cockroach/pull/119563#issuecomment-1960635701 applies here.
> Backports should only be created for serious issues or test-only changes. In an L2 incident involving a cluster that became unavailable and was deemed a P0 incident, the lack...
Is this abandoned?
Yep, I can confirm that in the minimal reproduction repro I linked in the issue, if I bump rules_go to use git_repository and commit 37ba8d5b, the error no longer reproduces....
I think we could slash the size of this change substantially and still get the utility we want to get -- asserting we actually downloaded -- without as much additional...
> SHOW BACKUP I'm not sure I understand what is being suggested here. This PR is adding a log of job state changes -- when it was paused, when it...
I don't think that is a jobs change -- that'd be a backup change. _This_ change is about adding logging of job changes to the jobs system. I imagine if...