xPendingReboot icon indicating copy to clipboard operation
xPendingReboot copied to clipboard

Update Module to meet HQRM Guidelines

Open PlagueHO opened this issue 8 years ago • 8 comments

This module needs to be updated to meet HQRM guidelines.

PlagueHO avatar Dec 10 '17 03:12 PlagueHO

@PlagueHO would this resource it better in ComputerManagementDsc instead of making this resource module HQRM? 🤔

johlju avatar May 03 '18 12:05 johlju

That is a really good question. It would be good to try and amalgamate some of these little single purpose resources. I'm all for it. What does the PS team think?

PlagueHO avatar May 03 '18 19:05 PlagueHO

The only negative I can see is that a user need to use a resource module with more code than maybe they would like. At the same time it is more work having resource spread out in several resource modules when there are no seemingly good reason for them to be the only resource in a resource module. I have asked the team for their thoughts.

I label this as need investigation, so that I can track it easier on the Waffle board. This does not stop this issue from being worked on.

johlju avatar May 04 '18 07:05 johlju

@PlagueHO The PS DSC Team is on-board with moving this (only got positive votes for moving). I opened an issue here https://github.com/PowerShell/DscResources/issues/374 to get community feedback,

johlju avatar May 10 '18 12:05 johlju

Awesome! I can fix some of the issues while I'm at it. :grin:

PlagueHO avatar May 10 '18 19:05 PlagueHO

@PlagueHO Great! 😃 Any issues not resolved we need to make sure we migrate.

johlju avatar May 11 '18 07:05 johlju

In progress now as I migrate this.

PlagueHO avatar Aug 10 '19 22:08 PlagueHO

This has been fixed over in the new PendingReboot in ComputerManagementDsc. @gaelcolas - can you close this one?

PlagueHO avatar Aug 17 '19 10:08 PlagueHO