xPSDesiredStateConfiguration
xPSDesiredStateConfiguration copied to clipboard
Help! Code Reviewers & Contributors Wanted!
Sending a request out to the community for help with performing code reviews on Pull Requests in this repository. Code reviewers of all skill sets are welcome. Review what you can, and if you think a second set of eyes is warranted via an additional review, just say so.
Here's some general guidelines and suggestions:
- Keep an eye out for Pull Requests that have the 'needs review' label
- If you are beginning a review on someone's Pull Request, add a comment in the PR saying you are doing so.
- Be familiar with the DSC Resource Style Guidelines & Best Practices, and be able to identify when the Style Guidelines aren't being followed.
- Be familiar with what is asked of contributers in the PULL REQUEST TEMPLATE
- Keep an eye out for scenarios where new Integration or Unit tests could be warranted (i.e. if a bug is fixed that could have been tested for, but no tests yet exist).
- Try to keep your review scoped to the actual changes being made (i.e. try not to request style changes on surrounding code that is not being modified as part of the PR). There's a lot of ongoing cleanup work on this module that still needs to be completed, but in most cases, those can be handled in separate Issues. Feel free to call out or open an Issue if surrounding code needs to be adjusted though, just don't make it a blocker.
Thanks!