WebAdministrationDsc icon indicating copy to clipboard operation
WebAdministrationDsc copied to clipboard

BREAKING CHANGE: xWebConfigProperty: Added Location to allow access to locked sections of ApplicationHost.Config

Open geoffguynn opened this issue 7 years ago • 13 comments

xWebConfigPropertyLocation: Added to allow access to locked sections of ApplicationHost.Config

Pull Request (PR) description

This new resource adds an additional parameter for the Location of the configuration property.

This Pull Request (PR) fixes the following issues

None

Task list

  • [x] Added an entry under the Unreleased section of the change log in the README.md. Entry should say what was changed, and how that affects users (if applicable).
  • [x] Resource documentation added/updated in README.md.
  • [x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
  • [X] Comment-based help added/updated.
  • [X] Localization strings added/updated in all localization files as appropriate.
  • [x] Examples appropriately added/updated.
  • [x] Unit tests added/updated. See DSC Resource Testing Guidelines.
  • [x] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • [x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

geoffguynn avatar Sep 30 '18 20:09 geoffguynn

CLA assistant check
All CLA requirements met.

msftclas avatar Sep 30 '18 20:09 msftclas

Codecov Report

Merging #400 into dev will decrease coverage by 0.02%. The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #400      +/-   ##
==========================================
- Coverage   90.67%   90.64%   -0.03%     
==========================================
  Files          17       17              
  Lines        2412     2405       -7     
==========================================
- Hits         2187     2180       -7     
  Misses        225      225
Impacted Files Coverage Δ
...FT_xWebConfigProperty/MSFT_xWebConfigProperty.psm1 92% <95%> (-0.99%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 85ff094...6e1bf9c. Read the comment docs.

codecov-io avatar Sep 30 '18 20:09 codecov-io

Hello @geoffguynn , thank you for submitting this PR. Can you please open an issue for this change? At first look, it appears that this is functionality that we can extend in the xWebConfigProperty resource instead of creating a new one. An open issue would be the best place for the community to discuss. Thank you!

regedit32 avatar Oct 01 '18 12:10 regedit32

As requested https://github.com/PowerShell/xWebAdministration/issues/401

geoffguynn avatar Oct 01 '18 14:10 geoffguynn

@geoffguynn There are still some failing tests in the AppVeyor build, so we'll wait to review until those are passing. Also, can you add unit and integration tests to validate the changes as well? We'll want to cover both scenarios of using the resource with and without a value for Location. Thanks!

regedit32 avatar Oct 10 '18 02:10 regedit32

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

stale[bot] avatar Nov 06 '18 07:11 stale[bot]

@regedit32 Had a few spare cycles to get back to this, let me know if there are any other changes needed.

geoffguynn avatar Jan 24 '19 20:01 geoffguynn

@geoffguynn Do you plan to continue working on this?

I would like to see this land and have time to work on the requested changes if needed.

psychonic avatar Jul 04 '19 17:07 psychonic

@psychonic I do, but I've been slammed with other work for awhile now. If you have some cycles, by all means :)

geoffguynn avatar Jul 16 '19 20:07 geoffguynn

I vote for this

varnav avatar Apr 20 '20 22:04 varnav

+1

danielmiu avatar May 04 '20 12:05 danielmiu

Curious if any work has been done on this in the last two years? If not, I'd be willing to pick up on finishing this.

randomnote1 avatar Jun 08 '22 17:06 randomnote1