BREAKING CHANGE: xWebConfigProperty: Added Location to allow access to locked sections of ApplicationHost.Config
xWebConfigPropertyLocation: Added to allow access to locked sections of ApplicationHost.Config
Pull Request (PR) description
This new resource adds an additional parameter for the Location of the configuration property.
This Pull Request (PR) fixes the following issues
None
Task list
- [x] Added an entry under the Unreleased section of the change log in the README.md. Entry should say what was changed, and how that affects users (if applicable).
- [x] Resource documentation added/updated in README.md.
- [x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
- [X] Comment-based help added/updated.
- [X] Localization strings added/updated in all localization files as appropriate.
- [x] Examples appropriately added/updated.
- [x] Unit tests added/updated. See DSC Resource Testing Guidelines.
- [x] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
- [x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.
Codecov Report
Merging #400 into dev will decrease coverage by
0.02%. The diff coverage is95%.
@@ Coverage Diff @@
## dev #400 +/- ##
==========================================
- Coverage 90.67% 90.64% -0.03%
==========================================
Files 17 17
Lines 2412 2405 -7
==========================================
- Hits 2187 2180 -7
Misses 225 225
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...FT_xWebConfigProperty/MSFT_xWebConfigProperty.psm1 | 92% <95%> (-0.99%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 85ff094...6e1bf9c. Read the comment docs.
Hello @geoffguynn , thank you for submitting this PR. Can you please open an issue for this change? At first look, it appears that this is functionality that we can extend in the xWebConfigProperty resource instead of creating a new one. An open issue would be the best place for the community to discuss. Thank you!
As requested https://github.com/PowerShell/xWebAdministration/issues/401
@geoffguynn There are still some failing tests in the AppVeyor build, so we'll wait to review until those are passing. Also, can you add unit and integration tests to validate the changes as well? We'll want to cover both scenarios of using the resource with and without a value for Location. Thanks!
Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.
@regedit32 Had a few spare cycles to get back to this, let me know if there are any other changes needed.
@geoffguynn Do you plan to continue working on this?
I would like to see this land and have time to work on the requested changes if needed.
@psychonic I do, but I've been slammed with other work for awhile now. If you have some cycles, by all means :)
I vote for this
+1
Curious if any work has been done on this in the last two years? If not, I'd be willing to pick up on finishing this.