NetworkingDsc icon indicating copy to clipboard operation
NetworkingDsc copied to clipboard

FirewallProfile: Fix issue #428 dsc firewallprofile

Open brajjan opened this issue 3 years ago • 4 comments

Pull Request (PR) description

Added PolicyStore parameter to Get/Set/Test-TargetResource for DSC_FirewallProfile - fixes Issue #428 .

Not updated Pester tests as my knowledge of Pester tests are close to 0

This Pull Request (PR) fixes the following issues

  • Fixes #428

Task list

  • [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
  • [ ] Resource documentation added/updated in README.md.
  • [x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
  • [ ] Comment-based help added/updated.
  • [ ] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [ ] Unit tests added/updated. See DSC Community Testing Guidelines.
  • [ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • [x] New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

brajjan avatar Sep 09 '22 10:09 brajjan

Codecov Report

Merging #519 (0863403) into main (9d6e70d) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #519   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        28     28           
  Lines      2078   2079    +1     
===================================
+ Hits       2028   2029    +1     
  Misses       50     50           
Impacted Files Coverage Δ
...urces/DSC_FirewallProfile/DSC_FirewallProfile.psm1 100% <100%> (ø)

codecov[bot] avatar Sep 09 '22 11:09 codecov[bot]

@brajjan when you are ready, take this PR out of draft so it can be reviewed.

johlju avatar Oct 01 '22 19:10 johlju