JeaDsc icon indicating copy to clipboard operation
JeaDsc copied to clipboard

PSSessionConfiguration - Adding 'AccessMode'

Open ZanattaMichael opened this issue 4 years ago • 5 comments

Pull Request (PR) description

Task list

  • [X] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
  • [X] Resource documentation added/updated in README.md in resource folder.
  • [ ] Resource parameter descriptions added/updated in schema.mof and comment-based help.
  • [X] Comment-based help added/updated.
  • [X] Localization strings added/updated in all localization files as appropriate.
  • [X] Examples appropriately added/updated.
  • [X] Unit tests added/updated. See DSC Resource Testing Guidelines.
  • [X] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • [X] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

ZanattaMichael avatar Oct 18 '21 23:10 ZanattaMichael

Hi There! I'm just following up on this PR to see if I need to make any changes.

Thanks!

Michael.

ZanattaMichael avatar Dec 06 '21 19:12 ZanattaMichael

@nyanhp or @raandree any chance you can check this PR pretty please :)

gaelcolas avatar Dec 10 '21 20:12 gaelcolas

Sorry for the huge delay, I will take care of this very soon.

raandree avatar May 07 '22 17:05 raandree

Codecov Report

Merging #50 (2cce90f) into master (7608302) will decrease coverage by 0%. The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #50   +/-   ##
====================================
- Coverage      35%   35%   -1%     
====================================
  Files           5     5           
  Lines         445   456   +11     
====================================
  Hits          160   160           
- Misses        285   296   +11     
Impacted Files Coverage Δ
source/Classes/1.SessionConfigurationUtility.ps1 0% <0%> (ø)
source/Classes/JeaSessionConfiguration.ps1 0% <0%> (ø)

codecov[bot] avatar May 11 '22 10:05 codecov[bot]

Hi @raandree. What needs to be done with this PR?

ZanattaMichael avatar Aug 14 '22 09:08 ZanattaMichael