xCluster*: Added support for distinguished cluster name

[IlleNilsson]

Pull Request (PR) description

Adds support for distinguished cluster name so one can place the cluster node in specific OU

This Pull Request (PR) fixes the following issues

Issue #256

Task list

• [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
• [ ] Resource documentation added/updated in README.md.
• [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
• [ ] Comment-based help added/updated.
• [ ] Localization strings added/updated in all localization files as appropriate.
• [ ] Examples appropriately added/updated.
• [ ] Unit tests added/updated. See DSC Community Testing Guidelines.
• [ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• [ ] New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[codecov[bot]]

Codecov Report

Merging #258 (bd656ae) into main (faa9aa3) will not change coverage. The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #258   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         8      9    +1     
  Lines       611    630   +19     
===================================
+ Hits        611    630   +19     

Impacted Files	Coverage Δ
source/DSCResources/DSC_Cluster/DSC_Cluster.psm1	100% <100%> (ø)
...usterPreferredOwner/DSC_ClusterPreferredOwner.psm1	100% <100%> (ø)
...urces/DSC_ClusterProperty/DSC_ClusterProperty.psm1	100% <100%> (ø)
...sources/DSC_WaitForCluster/DSC_WaitForCluster.psm1	100% <100%> (ø)
...erClusterDsc.Common/FailoverClusterDsc.Common.psm1	100% <100%> (ø)

[johlju]

I need to have time to look into this change. I will try to get to it as soon as possible, but having a lot on my plate at the moment.

[johlju]

If you can add unit tests to the changes in the PR so they changes is being tested. That would help as I need that to merge the code.

[dennisl68-castra]

@IlleNilsson Could you please have a look at the failed Unit tests?
They don't seem very hard to fix...

[IlleNilsson]

I do not know where to start. But it would be a great opportunity for you to familiarize with the DSC community.

---

From: dennisl68-castra @.> Sent: Thursday, September 23, 2021 3:50:03 PM To: dsccommunity/xFailOverCluster @.> Cc: Ilian Nilsson @.>; Mention @.> Subject: Re: [dsccommunity/xFailOverCluster] xCluster*: Added support for distinguished cluster name (#258)

@IlleNilssonhttps://github.com/IlleNilsson Could you please have a look at the failed Unit tests? They don't seem very hard to fix...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/dsccommunity/xFailOverCluster/pull/258#issuecomment-925834415, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AID6F4BH54SWIVJX73CNRIDUDMWAXANCNFSM43EHIDZA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[dennisl68-castra]

@IlleNilsson Perhaps you could review the failed Unit Tests in this Pull Request (look at the Details of each failed stage of Review requested) and remedy the failures of your request and then push your code again for a new review?

[IlleNilsson]

I already communicated with the community and stated that I can fix the actual problem but I’m not skilled enough to fix tests.

---

From: dennisl68-castra @.> Sent: Thursday, September 23, 2021 4:12:07 PM To: dsccommunity/xFailOverCluster @.> Cc: Ilian Nilsson @.>; Mention @.> Subject: Re: [dsccommunity/xFailOverCluster] xCluster*: Added support for distinguished cluster name (#258)

@IlleNilssonhttps://github.com/IlleNilsson Perhaps you could review the failed Unit Tests in this Pull Request (look at the Details of each failed stage of Review requested) and remedy the failures of your request and then push your code again for a new review?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/dsccommunity/xFailOverCluster/pull/258#issuecomment-925853828, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AID6F4ECB7KGL3W4IX5R7VLUDMYTPANCNFSM43EHIDZA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[dennisl68-castra]

@johlju The build isn't available anymore so I can't review the failed tests... I'll try to find some of the issues by hand and then pushing the changes to trigger new builds and tests...

[dennisl68-castra]

If you can add unit tests to the changes in the PR so they changes is being tested. That would help as I need that to merge the code.

Ok, so what's missing now is additional unit tests for the added functionality? I think I can have a resource available for that in a couple of weeks on our side (I don't know how to write proper Unit tests myself yet)...

[dennisl68-castra]

As we will drop the use of xCluster, I will not pursue this Pull Request.

[johlju]

This PR is ready for someone to continue running with it. Let me know when it needs another review. 🙂

[stale[bot]]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.