ComputerManagementDsc icon indicating copy to clipboard operation
ComputerManagementDsc copied to clipboard

PSResource: New resource proposal

Open nickgw opened this issue 3 years ago • 2 comments

Resource proposal

This is a duplicate of Issue #393 , but scoped solely to the proposed PSResource resource.

Currently, psmodule is bundled in the PowershellGet v2 module. In PowerShellGet v3 the resources has been moved into a new, dsc specific module, PowerShellGetDsc. Unfortunately, these repositories are either no longer maintained, or have not had any activity in years.

I'm proposing taking the resources and moving them into ComputerManagementDsc with new names to avoid multiple DSC resources with the same name. This way, the community can add features and bug fixes more rapidly. If there comes a time that PowershellGetDsc is actively maintained, we can take the contributions from ComputerManagementDsc and port them over.

https://github.com/PowerShell/PowerShellGetDsc - no contributions in 11 months, no target production release https://github.com/PowerShell/PowerShellGet - does not include Dsc resources anymore https://github.com/PowerShell/PowerShellGetv2 - Contains PSModule and PSRepository, no longer in development and not accepting any pull requests

Proposed properties

[ClassVersion("1.0.0.0"),FriendlyName("PSModule")] class MSFT_PSModule : OMI_BaseResource { [Key] String Name; [Write,ValueMap{"Present", "Absent"},Values{"Present", "Absent"}] String Ensure; [Write] String Repository; [Write,ValueMap{"Trusted", "Untrusted"},Values{"Trusted", "Untrusted"}] String InstallationPolicy; [Write] Boolean Trusted; [Write] String Version; [Write] Boolean NoClobber; [Write] Boolean SkipPublisherCheck; [Read] string Description; [Read] String InstalledVersion; [Read] String Guid; [Read] String ModuleBase; [Read] String ModuleType; [Read] String Author; };

Special considerations or limitations

There may come a time when psmodule is actively developed and we should work to contribute any fixes or features from ComputerManagementDsc to the official repository.

nickgw avatar Nov 17 '22 18:11 nickgw

@johlju I've got some questions about the design of this resource.

For the properties MaximumVersion, and MinimumVersion does specifying a state of one of them mean all resources out of compliance are uninstalled, or do we just say the resource is in the correct state if a single resource meets the critera.

For example: Given this resource declaration:

$Params = @{
  Name = 'PSResource'
  ModuleName = 'ComputerManagementDsc'
  Property = @{
    Name   = 'jeadsc'
    Ensure = 'Present'
    MaximumVersion = '0.6.0'
  }
  Method = 'Get'
}

and this result of Get-Module -Name JeaDsc -ListAvailable

PS C:\Users\vagrant> Get-Module -Name JeaDsc -ListAvailable


    Directory: C:\Program Files\WindowsPowerShell\Modules


ModuleType Version    Name                                ExportedCommands                                                                                                           
---------- -------    ----                                ----------------                                                                                                           
Script     0.7.2      JeaDsc                              ConvertTo-Expression                                                                                                       
Script     0.6.0      JeaDsc                              {Compare-JeaConfiguration, Convert-ObjectToHashtable, Convert-StringToObject}

Is the resource in compliance because JeaDsc version 6.0.0 meets the resource, or out of spec because 0.7.2 exceeds it and we need to uninstall 0.7.2?

Similar question for RequiredVersion, but I think it's more cut and dry that as long as the resource of the requiredversion exists, we're in the correct state.

thanks!

nickgw avatar Nov 27 '22 21:11 nickgw

@johlju I've got some questions about the design of this resource.

For the properties MaximumVersion, and MinimumVersion does specifying a state of one of them mean all resources out of compliance are uninstalled, or do we just say the resource is in the correct state if a single resource meets the critera.

For example: Given this resource declaration:

$Params = @{
  Name = 'PSResource'
  ModuleName = 'ComputerManagementDsc'
  Property = @{
    Name   = 'jeadsc'
    Ensure = 'Present'
    MaximumVersion = '0.6.0'
  }
  Method = 'Get'
}

and this result of Get-Module -Name JeaDsc -ListAvailable

PS C:\Users\vagrant> Get-Module -Name JeaDsc -ListAvailable


    Directory: C:\Program Files\WindowsPowerShell\Modules


ModuleType Version    Name                                ExportedCommands                                                                                                           
---------- -------    ----                                ----------------                                                                                                           
Script     0.7.2      JeaDsc                              ConvertTo-Expression                                                                                                       
Script     0.6.0      JeaDsc                              {Compare-JeaConfiguration, Convert-ObjectToHashtable, Convert-StringToObject}

Is the resource in compliance because JeaDsc version 6.0.0 meets the resource, or out of spec because 0.7.2 exceeds it and we need to uninstall 0.7.2?

Similar question for RequiredVersion, but I think it's more cut and dry that as long as the resource of the requiredversion exists, we're in the correct state.

thanks!

https://github.com/dsccommunity/ComputerManagementDsc/issues/399#issuecomment-1328288382

nickgw avatar Nov 27 '22 21:11 nickgw