CommonTasks icon indicating copy to clipboard operation
CommonTasks copied to clipboard

Fixed type errors in 'RemoteDesktopCollections' and 'RemoteDesktopDeployment'

Open raandree opened this issue 3 years ago • 1 comments

Pull Request

Pester tests failed for 'RemoteDesktopCollections' and 'RemoteDesktopDeploymentMade'. 'SessionHost' defined as an array but is a scalar in the underlying DSC resources.

Pull Request (PR) description

Fixed

  • SessionHost is now a scalar in 'RemoteDesktopCollections' and 'RemoteDesktopDeploymentMade'.

Task list

  • [x] The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • [x] Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • [x] Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • [ ] Resource documentation added/updated in README.md.
  • [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
  • [ ] Comment-based help added/updated.
  • [ ] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [x] Unit tests added/updated. See DSC Resource Testing Guidelines.
  • [x] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • [x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

raandree avatar Sep 12 '22 07:09 raandree

Future release of RemoteDesktop DSC resources will support a list of session hosts. I'll convert this PR to a draft until that happens

nyanhp avatar Sep 15 '22 11:09 nyanhp