patch-package icon indicating copy to clipboard operation
patch-package copied to clipboard

Add node 20/22 to test matrix

Open Rishi556 opened this issue 1 year ago β€’ 3 comments

Rishi556 avatar Oct 17 '24 13:10 Rishi556

Nice! From April 30th 2025, 20 and 22 will be the only supported node versions: https://endoflife.date/nodejs

Perhaps it makes sense to also drop support for node 14 and 16 soon.

stianjensen avatar Dec 18 '24 18:12 stianjensen

@stianjensen I’ll let the maintainers decide that. But as long as it works on a older version, I don’t see a need to drop it from the test matrix, can always remove it down the line when a breaking change is needed.

Rishi556 avatar Dec 18 '24 18:12 Rishi556

I believe the question of running tests on older Node.js versions hinges on whether the package aims to support those versions. If tests start failing on older versions, should the code be modified to accommodate them? If no actions will be taken when compatibility with EOL (End of Life) versions of Node.js breaks, why would we continue running those tests? It's like adding unnecessary resource consumption without benefit. 🌎πŸ”₯

YasharF avatar Feb 01 '25 02:02 YasharF