patch-package icon indicating copy to clipboard operation
patch-package copied to clipboard
verified publisher icon ds300

Using `--create-issue` result in bad request.

Open mthines opened this issue 4 years ago • 10 comments

Hey!

When using the --create-issue, Github is giving an error saying the Your request URL is too long..

image

mthines avatar Jun 27 '21 08:06 mthines

Same problem!

bunnybones1 avatar Oct 16 '21 06:10 bunnybones1

The same problem

sergeymild avatar Mar 17 '22 12:03 sergeymild

Same problem

vladimirevstratov avatar Sep 07 '22 10:09 vladimirevstratov

May be use url shortener?

vladimirevstratov avatar Sep 07 '22 10:09 vladimirevstratov

Same

nabilfreeman avatar Nov 08 '22 17:11 nabilfreeman

We should detect if it's too long (~500 chars) and not offer to do the issue

orta avatar Nov 08 '22 20:11 orta

Cant report a problem via CLI due to this :/

@ds300 can I add a check here to avoid sending requests to the Github page URL with more than the permitted length?

https://github.com/ds300/patch-package/blob/0b9b0150a2348bf53087198fcad84e862a35eebb/src/createIssue.ts#L99-L124

bombillazo avatar May 28 '23 03:05 bombillazo

Sure!

ds300 avatar May 28 '23 06:05 ds300

Awesome, @ds300 ! Here's the PR https://github.com/ds300/patch-package/pull/469

Feedback is welcome

bombillazo avatar May 28 '23 20:05 bombillazo

Hey, had to create a new PR since the old was closed when I merged the latest repo changes to my forked repo.

bombillazo avatar Sep 11 '23 16:09 bombillazo