commerce icon indicating copy to clipboard operation
commerce copied to clipboard

Issue #2857378 by bojanz, vasike, mglaman: Hide order activity when empty

Open vasike opened this issue 8 years ago • 2 comments

vasike avatar Mar 06 '17 11:03 vasike

phpcs issues

The command "phpcs --standard=phpcs.xml src -s" exited with 0.
7.39s$ phpcs --standard=phpcs.xml modules -s
FILE: ...erce/modules/log/tests/src/Functional/OrderAdminActivityTest.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 17 | ERROR | [x] Do not append variable name "$order" to the type
    |       |     declaration in a member variable comment
    |       |     (Drupal.Commenting.VariableComment.InlineVariableName)
 68 | ERROR | [x] Expected 1 blank line after function; 0 found
    |       |     (Squiz.WhiteSpace.FunctionSpacing.After)
 69 | ERROR | [x] The closing brace for the class must have an empty line
    |       |     before it
    |       |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

mglaman avatar Mar 09 '17 21:03 mglaman

it seems this fails because of this https://github.com/drupalcommerce/commerce/pull/711 issue: https://www.drupal.org/node/2867430

vasike avatar Apr 06 '17 14:04 vasike