ddev-ui icon indicating copy to clipboard operation
ddev-ui copied to clipboard

Bundle ddev in ddev-ui package build

Open rfay opened this issue 8 years ago • 3 comments

What happened (or feature request):

We should really bundle ddev with ddev-ui in the package build, rather than having it be a prereq. That lets us force the version of ddev, which is nice.

When we do it, we should make sure that

  • It's versioned properly (that ddev-ui is specifying a working version of ddev
  • That the installed ddev is then available via the command-line (is in path) - we don't want people ending up with 2 different ddevs on their machine if we can help it.

What you expected to happen:

How to reproduce this:

Version: Please include the output of ddev version, docker version and the project's .ddev/config.yaml.

Anything else do we need to know:

Related source links or issues:

rfay avatar Oct 02 '17 14:10 rfay

@rfay So are we wanting to bundle the CLI by detecting if DDEV CLI exists, is the right version, what OS and then curl https://raw.githubusercontent.com/drud/ddev/master/install_ddev.sh | bash for Linux and Mac users? I'm not sure of the windows equivalent?

Or did you have something more elegant in mind?

alkymst avatar Aug 13 '18 19:08 alkymst

Or are you thinking actually including the binary in the UI repo?

alkymst avatar Aug 13 '18 19:08 alkymst

I was thinking that we would include the binary (by getting it from the github releases URL)

rfay avatar Aug 13 '18 22:08 rfay