metrics icon indicating copy to clipboard operation
metrics copied to clipboard

Roadmap: Dropwizard Metrics 5.0.x

Open hdost opened this issue 5 years ago • 20 comments

Remaining Tasks

  • [x] #1735
  • [x] #1736
  • [ ] #2055

hdost avatar Nov 09 '20 12:11 hdost

There are currently no further plans for Dropwizard Metrics 5.x.

Once there are, you will be able to see the scheduled work in the 5.0.0 milestone.

joschi avatar Nov 09 '20 13:11 joschi

@joschi Ok, that's fine, but what I can't find is the reasons there are no further plans. Why did it get paused? What would bring it back? etc.

hdost avatar Nov 09 '20 13:11 hdost

Ok, that's fine, but what I can't find is the reasons there are no further plans.

There are currently not enough active maintainers and contributors pushing the agenda forward.

What would bring it back? etc.

Active long-time contributions from interested parties. 😃

CC: @dropwizard/metrics

joschi avatar Nov 09 '20 13:11 joschi

@hdost Sorry that I sounded too harsh.

The issue right now is a lack of people who would be willing to invest substantial time and work into Dropwizard Metrics 5.x.

Past updates with backward-incompatible changes (e. g. Dropwizard Metrics 3.x -> 4.x) have shown that only a small number of people are willing to invest in the update once it's been released.

This leads to the situation that there are a lot of consumers still using an outdated and unsupported version of Dropwizard Metrics: https://twitter.com/dropwizardio/status/1259130162794373122

metrics-core usage in May 2020

With this in mind, I'm wondering if investing any time into yet another major version with breaking changes (which would have to be picked up by consumers) currently makes sense.

joschi avatar Nov 09 '20 16:11 joschi

I appreciate the feedback :) we're currently looking at our efforts internally and we're hoping to implement tagging/labels for our metrics, but that's only in the 5.x branch for now.

hdost avatar Nov 13 '20 14:11 hdost

Hey @hdost and @joschi! Artem is here, I originally started the work on Metrics 5 a couple of years ago, but have been working on it only sporadically. I've recently merged the latest changes from the release/4.1 and release/4.2 branches to 5.0-development. The test suite is green now and Metrics 5.0 is usable to integrate directly or via the Metrics4 adapter. I can cut a new release candidate in Maven Central and see what are outstanding issues for Metrics 5. The most interesting use case would be to see how it integrates with Micrometer which already supports tags. Luckily, I'm going to have to have some free time in November - December because of the lockdown and I think it would be a good opportunity to finally release Metrics 5 in the wild!

arteam avatar Nov 15 '20 13:11 arteam

Running sums are another feature I'd love to see get an official release: #1254

Sharpie avatar Nov 18 '20 17:11 Sharpie

@arteam is there some sort of investigation or work I could help with?

hdost avatar Nov 21 '20 13:11 hdost

@arteam :wave: I've done a little bit of testing with the micrometer library, but I could also just be missing things it seems to be working alright.

hdost avatar Dec 16 '20 10:12 hdost

Hi

Do you have any ideas/plans to support Jakarta EE 9 in 5.x branch ?

sergey-morenets avatar Jan 05 '21 21:01 sergey-morenets

I noticed that metrics-servlets module in 5.x branch , for example, still uses Servlet API 4:

https://github.com/dropwizard/metrics/blob/5.0-development/metrics-servlets/pom.xml

sergey-morenets avatar Jan 05 '21 21:01 sergey-morenets

I noticed that metrics-servlets module in 5.x branch , for example, still uses Servlet API 4:

@sergey-morenets Would you be able to provide a forward-port of https://github.com/dropwizard/metrics/pull/1730 into the release/5.0.x branch?

joschi avatar Jan 06 '21 12:01 joschi

@sergey-morenets Or better, port the missing functionality from release/4.2.x to release/5.0.x?

joschi avatar Jan 06 '21 12:01 joschi

@sergey-morenets Or better, port the missing functionality from release/4.2.x to release/5.0.x?

Thank you for suggestion. But I'm not sure if I have even permissions to work on this project.

sergey-morenets avatar Jan 06 '21 14:01 sergey-morenets

Thank you for suggestion. But I'm not sure if I have even permissions to work on this project.

@sergey-morenets You can fork the project and create a pull request. 😃

https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

joschi avatar Jan 06 '21 15:01 joschi

@arteam Could you please reconcile the 5.0-development and release/5.0.x branches (#1735) and port the changes from release/4.2.x to release/5.0.x (#1736)?

joschi avatar Jan 10 '21 21:01 joschi

What is the status of the 5.0.x version? Will it ever be released?

Tagged/Labeled metrics is quite a big thing... and metrics 4.x does not have it.

mbrannstrom avatar Sep 20 '21 11:09 mbrannstrom

I am also looking for an answer for @mbrannstrom question related to tags feature. Any good news folks ?

shahbaaz31here avatar Apr 18 '22 11:04 shahbaaz31here

@shahbaaz31here It's simple: If somebody steps up as a permanent maintainer for the Dropwizard Metrics 5.x branch, we can release it.

joschi avatar Apr 18 '22 11:04 joschi

Thanks @joschi . Does anyone know if there is any custom library available for adding tags ? We can use that until 5.x version comes.

shahbaaz31here avatar Apr 19 '22 05:04 shahbaaz31here