Mapping of common attribute now keeps the initial fields
The mapping done by esaml works well but does not add the initial fields to the result. This PR solves the matter by keeping all the data sent by the IDPs. This helped us to provide helpful logs for debugging and clearly improve maintainability.
From our test, this has no impact on the current implementation. While I don't expect a direct merge, I hope to gather some of your feedbacks/ideas.
Before this change:
%{
givenName: 'Student',
mail: '[email protected]',
surName: 'One',
uid: 'student1',
"urn:mace:dir:attribute-def:givenName": 'Student',
"urn:mace:dir:attribute-def:mail": '[email protected]',
"urn:mace:dir:attribute-def:sn": 'One',
"urn:mace:dir:attribute-def:uid": 'student1',
"urn:oid:1.3.6.1.4.1.25178.1.2.9": 'xxx.nl'
}
After this change:
%{
:givenName => 'Student',
:mail => '[email protected]',
:surName => 'One',
:uid => 'student1',
:"urn:mace:dir:attribute-def:givenName" => 'Student',
:"urn:mace:dir:attribute-def:mail" => '[email protected]',
:"urn:mace:dir:attribute-def:sn" => 'One',
:"urn:mace:dir:attribute-def:uid" => 'student1',
:"urn:oid:1.3.6.1.4.1.25178.1.2.9" => 'xxx.nl',
'urn:mace:dir:attribute-def:givenName' => 'Student',
'urn:mace:dir:attribute-def:mail' => '[email protected]',
'urn:mace:dir:attribute-def:sn' => 'One',
'urn:mace:dir:attribute-def:uid' => 'student1',
'urn:mace:terena.org:attribute-def:schacHomeOrganization' => 'xxx.nl',
'urn:oid:0.9.2342.19200300.100.1.1' => 'student1',
'urn:oid:0.9.2342.19200300.100.1.3' => '[email protected]',
'urn:oid:1.3.6.1.4.1.25178.1.2.9' => 'xxx.nl',
'urn:oid:2.5.4.4' => 'One',
'urn:oid:2.5.4.42' => 'Student'
}
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.