dropbox-sdk-obj-c icon indicating copy to clipboard operation
dropbox-sdk-obj-c copied to clipboard

Missing app icon in login page for iPhone (but present in iPad)

Open magicboker opened this issue 9 years ago • 6 comments

The WebAuth login page used to show my app icon by using v1 API, but it missed the app icon when using v2 API with this SDK for iPhone. Like this missing app icon

I am using the latest version of the SDK here. It's weird that the app icon is always present on iPad with exactly the same code. Why??

My code snippet:

[DropboxClientsManager authorizeFromController: [UIApplication sharedApplication] controller: controller openURL: ^(NSURL *url) {
	[self handleAuthenticationResult: controller url: url];
} browserAuth: NO];

magicboker avatar Nov 18 '16 10:11 magicboker

Thanks for the report! The mobile version of the OAuth 2 app authorization flow only shows the Dropbox logo during sign in, but the app's icon is shown next during the app authorization. We'll consider this a request for showing the app icon during sign in on mobile as well.

greg-db avatar Nov 18 '16 18:11 greg-db

Why the app icon was shown in the WebAuth login page on iPad with exactly the same code? Did your web server detect the client type to determine what to show on the page?

magicboker avatar Nov 18 '16 18:11 magicboker

Yes, the iPad has more room so it gets the "desktop" version of that page.

greg-db avatar Nov 18 '16 18:11 greg-db

You don't need to have extra place to show my app icon on iPhone. Where the dropbox icon is shown in SDK v2 used to show my app icon in SDK v1 on iPhone.

magicboker avatar Nov 18 '16 18:11 magicboker

Thanks! I've sent this along to the team to see if we can make that change for v2.

greg-db avatar Nov 18 '16 18:11 greg-db

Thanks, look forward to the change!

magicboker avatar Nov 18 '16 18:11 magicboker