PyHive icon indicating copy to clipboard operation
PyHive copied to clipboard

Support presto Decimal, Date and Timestamp types

Open devinstevenson opened this issue 8 years ago • 2 comments

Hi @jingw.

I added support on Presto for decimal, date, and timestamp presto types. I also modified the tests to include a date type. The Travis CI test failed on python 3.6 seems to be a Travis CI issue. The tests passed on all other versions of python.

devinstevenson avatar Oct 27 '17 18:10 devinstevenson

Codecov Report

Merging #171 into master will decrease coverage by 0.24%. The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   95.71%   95.47%   -0.25%     
==========================================
  Files          14       14              
  Lines        1422     1457      +35     
  Branches      147      149       +2     
==========================================
+ Hits         1361     1391      +30     
- Misses         40       44       +4     
- Partials       21       22       +1
Impacted Files Coverage Δ
pyhive/tests/test_hive.py 97.7% <ø> (ø) :arrow_up:
pyhive/tests/test_presto.py 96.36% <ø> (-3.64%) :arrow_down:
pyhive/tests/test_sqlalchemy_hive.py 100% <100%> (ø) :arrow_up:
pyhive/presto.py 94% <100%> (+0.38%) :arrow_up:
pyhive/tests/test_sqlalchemy_presto.py 100% <100%> (ø) :arrow_up:
pyhive/sqlalchemy_presto.py 91.97% <95.45%> (+0.59%) :arrow_up:
pyhive/hive.py 90.09% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b68e1a8...85ebb50. Read the comment docs.

codecov-io avatar Oct 27 '17 18:10 codecov-io

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Devin Stevenson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 16 '22 21:04 CLAassistant