drogon icon indicating copy to clipboard operation
drogon copied to clipboard

Enable Address Sanitizer

Open ken-matsui opened this issue 3 years ago • 8 comments

To detect problems related to memories. I believe CIs will fail.

ken-matsui avatar Jul 30 '22 20:07 ken-matsui

A UAF occurred on the CookieSameSite test.

https://github.com/drogonframework/drogon/runs/7599602869?check_suite_focus=true#step:15:61235

ken-matsui avatar Jul 31 '22 15:07 ken-matsui

@ken-matsui please rebase on the master branch, thanks.

an-tao avatar Aug 01 '22 06:08 an-tao

Why the Linux rests have been removed in this PR?

an-tao avatar Aug 01 '22 06:08 an-tao

I didn't remove them. I thought there's something like new actions needed to be enabled by repository owners.

ken-matsui avatar Aug 01 '22 06:08 ken-matsui

@an-tao I mean, could you please check if there's confirmation to run new actions, or that you commit this on my behalf might work?

ken-matsui avatar Aug 11 '22 03:08 ken-matsui

@an-tao I mean, could you please check if there's confirmation to run new actions, or that you commit this on my behalf might work?

I don't quite understand what you're trying to express, but this PR should guarantee that all actions run.

an-tao avatar Aug 11 '22 08:08 an-tao

Ah, I thought I do not have write access is the reason, but it is also reproduced on my repository. https://github.com/ken-matsui/drogon/pull/1

So, the action file is something wrong. Thank you for your answer!

ken-matsui avatar Aug 11 '22 09:08 ken-matsui

@an-tao I could hook Linux actions! Thank you :)

Would you want me to revert this commit https://github.com/drogonframework/drogon/pull/1335/commits/a84818d4fd43e5162adac704f8134b702a1b2bec?

ken-matsui avatar Aug 11 '22 10:08 ken-matsui