tlsx icon indicating copy to clipboard operation
tlsx copied to clipboard
verified publisher icon dreadl0ck

ClientHelloBasic: add len check on ExtServerName in Unmarshal

Open ds-281 opened this issue 1 year ago • 0 comments

Hello,

While fingerprinting some clientHellos, I stumbled on the bug this commit fixes.

The fix from 0660b600 has only addressed the issue for the function Unmarshal from ClientHello. This commit addresses the same problem for ClientHelloBasic, which is used for ja3 fingerprinting.

I would also suggest bumping the version of tlsx in ja3's go.mod (otherwise it would defeat the purpose of this change).

All the best, Damien.

ds-281 avatar Feb 05 '25 09:02 ds-281