Chris Brown

If the real concern is protecting against false-flagging of duplicate content, then I suggest the best approach is to actually throw a 404 not found every time there is no...

I fully agree that the store should make its best efforts to give the customer what they were seeking for regardless of any imperfection in their "ask". We used to...

> because of how stupid-simple it is... While on the surface it may look "stupid-simple", we need to be certain there are no undesired side-effects, not just regarding code/variables, but...

1. Yes, I agree: `$_GET['keywords']` should be `$_GET['keyword']` 2. "i think the $keywords in the notifier should be the actual one used in the search." Does this work: ```diff -...

> `$possible_guards` appears to return `['web', 'api']` in this order. If $possible_guards is not a single value, then it is coming from `getConfigAuthGuards()`: https://github.com/spatie/laravel-permission/blob/05f620c903f632a9ed26cb5e81d1c5e86601669c/src/Guard.php#L41-L56 ... which uses collection methods to...

@sts-ryan-holton I've been considering adding a config setting for what guards you "want" the package to look at, in that order. And if the list is blank it'll fallback to...

Yes, this and a few other things need updating for full PHP 8.4 compatibility.

`SID` is only defined when PHP "needs" to define it. And that should only be when all the more modern approaches to session handling "fail". So, I'm reluctant to directly...

(Yes, I "would" like to rip all that old stuff out. But in a major release version.)

> Can this be reproduced using the current unmodified contents of the Github master branch? No because I've got it [suppressed](https://github.com/zencart/zencart/commit/b452f001f78d43a5ae9eca95c02dd6332e11bd71) via: https://github.com/zencart/zencart/blob/827e3ea12f5edf4fc6531622e1eb2b621d4aefe7/includes/functions/functions_error_handling.php#L43-L44