Daniel Bergman comments

Results 65 comments of


                                            Daniel Bergman

Clarifying attack/damage rates

See #224

Clarifying attack/damage rates

Going to be addressed in a soon-to-be-opened PR from development-paul

saving rules v1 instead of v2 to /output

I believe that means that it also prints the base value, correct? Which I find useful. https://github.com/MathCancer/PhysiCell/blob/3d7051f167b6b3551296a4b6d93db742dc532ee6/core/PhysiCell_rules.cpp#L2181-L2184

getter functions for lists of dying and dividing cells

Is your custom code in `custom_modules`? Or is it custom additions to `update_all_cells`? The main concern about adding these functions in to core PhysiCell is where in the code others...

getter functions for lists of dying and dividing cells

Ah I see. Yeah, the phenotype functions are run in parallel and prior to what I labeled above as 'a' within `advance_bundled_phenotype_functions`. If I'm reading this correctly, you have not...

getter functions for lists of dying and dividing cells

Hi @josephabrams, just wanted to follow up and see what your thoughts are about this PR. Do you want to leave it open and have it merged (perhaps after new...

getter functions for lists of dying and dividing cells

@MathCancer this can be closed

make reset - avoid "rm *.cpp"?

I would advocate for not changing the functionality of these common commands. I and others have come to rely on them and what they do. I don't see any of...

make reset - avoid "rm *.cpp"?

See a comment at the (current) bottom of this PR #244 regarding whether `make clean` should be inside `make reset`. Link: https://github.com/MathCancer/PhysiCell/pull/244#issuecomment-2294103509. As I recall, this was added during a...

updated scripts to build, run, test all sample projects

I'm trying this out to test the arg parser and noticing the template project produces a file called `template` (on non-Windows) and the mechano-sample produces a file called `mechano-sample`. Subsequent...