Dragonfly2 icon indicating copy to clipboard operation
Dragonfly2 copied to clipboard

Wrong parsing of IPv6 address in dfdaemon

Open PKizzle opened this issue 2 years ago • 1 comments

Bug report:

grpclog/grpclog.go:37	[core][Channel #683] Channel created
grpclog/grpclog.go:37	[core][Channel #683] original dial target is: "[fd01:0:0:2::52eb]:8002"
grpclog/grpclog.go:37	[core][Channel #683] dial target "[fd01:0:0:2::52eb]:8002" parse failed: parse "[fd01:0:0:2::52eb]:8002": first path segment in URL cannot contain colon
grpclog/grpclog.go:37	[core][Channel #683] fallback to scheme "passthrough"
grpclog/grpclog.go:37	[core][Channel #683] parsed dial target is: {Scheme:passthrough Authority: URL:{Scheme:passthrough Opaque: User: Host: Path:/[fd01:0:0:2::52eb]:8002 RawPath:/[fd01:0:0:2::52eb]:8002 OmitHost:false ForceQuery:false RawQuery: Fragment: RawFragment:}}
grpclog/grpclog.go:37	[core][Channel #683] Channel authority set to "[fd01:0:0:2::52eb]:8002"

Expected behavior:

No error message should be output as the IPv6 address is correctly parsed and only the last colon outside the square brackets is considered a delimiter for the port.

How to reproduce it:

  1. Run dragonfly in a IPv6 enabled kubernetes cluster
  2. Enable console output for dfdaemon
  3. Check the console output for dfdaemon

Environment:

  • Dragonfly version: v2.1.0-beta.1
  • OS: Raspberry Pi OS (Debian)
  • Kernel: 6.1.21-v8+ aarch64 GNU/Linux
  • Redis: 7.2-rc2

PKizzle avatar Jul 24 '23 01:07 PKizzle

I have seen this as well with IPv4, the same error message "first path segment in URL cannot contain colon"

@gaius-qi @jim3ma

embroede avatar Dec 21 '23 01:12 embroede