next icon indicating copy to clipboard operation
next copied to clipboard

call plugin onChange method

Open hosmelq opened this issue 7 years ago • 4 comments

hosmelq avatar Oct 02 '18 04:10 hosmelq

@hosmelq I actually think removing onChange from plugin methods simplifies the API. It's also little bit confusing, like - as a user I'm not sure if this means I'm listening to events or updating the state, in the previous versions of plugins this is both - which is imo super confusing.

I don't think it's needed really...

juliankrispel avatar Oct 02 '18 07:10 juliankrispel

Perfect, I like the idea. You can close this whenever you want.

hosmelq avatar Oct 03 '18 04:10 hosmelq

Sweet. Hey btw if you’re interested in contributing maybe we could pair sometime? If you’re down ping me on slack or twitter plz 👍 On Wed, Oct 3, 2018 at 5:04 AM Hosmel Quintana [email protected] wrote:

Perfect, I like the idea. You can close this whenever you want.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/draft-js-plugins/next/pull/3#issuecomment-426505099, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIhWvE41t5x64gPZiaBueWer-llbiBBks5uhDdrgaJpZM4XDTIg .

juliankrispel avatar Oct 03 '18 06:10 juliankrispel

Gracias @juliankrispel, no sé mucho sobre borrador, pero podría ayudar. 🙂

hosmelq avatar Oct 08 '18 01:10 hosmelq