vim icon indicating copy to clipboard operation
vim copied to clipboard

Add strikethrough attribute support

Open stnley opened this issue 1 year ago • 5 comments

This adds another configurable attribute for strikethrough text, along with a default foreground group.

stnley avatar Feb 04 '24 21:02 stnley

I don't see this used anywhere, so why do we need it? Perhaps you accidentally left off the use?

benknoble avatar Feb 04 '24 22:02 benknoble

I am preparing a PR with a treesitter highlight which uses this. I hoped it would be easier to process this separately.

Admittedly it is just one group that will use it so if we don't want to have to maintain this no big deal.

stnley avatar Feb 04 '24 22:02 stnley

Oh, that makes sense. Reading is easier broken up, but understanding the purpose helps.

benknoble avatar Feb 04 '24 23:02 benknoble

I think I'd still like to see the follow-up to get a better idea of how this is used, esp. since I'd prefer not to merge this without a concrete use.

benknoble avatar Feb 08 '24 01:02 benknoble

Thanks for your patience, I've opened the follow up which uses this feature.

stnley avatar Feb 18 '24 02:02 stnley