dpsutton

Results 81 comments of dpsutton

Good bump! I had no idea about this and this is my fault.

@alexander-yakushev After looking at this I don't think that I actually broke this but its a bit scary. I messed with this arcane machinery once to handle the top level...

note to self: - mention jvm options (eg, "-J-Djdk.attach.allowAttachSelf" see comments on https://github.com/clojure-emacs/cider/pull/2970) - mention aliases in `cider-clojure-cli-global-options` (current behavior) and `cider-clojure-cli-aliases` - this is a bit of a workaround...

@willbryant we recreated this PR in https://github.com/metabase/metabase/pull/27614 to add some tests and remove the Category regex match. Category is usually matched from the cardinality of a field rather than its...

@mehw nice work! I'm really liking it and it looks really good for the codebase. I've applied your patch locally to test it and have a few notes: - the...

Also need to make sure that the tests pass. I need to update the matrix of which emacs it runs in. Currently its set to emacs 24 :(

> may I ask for help to you If I'm in trouble? Absolutely! Happy to help and I really appreciate the work you have already done. About squashing, I'm not...

@mehw I've been looking over it and I'm quite pleased. You've certainly done a lot to improve the codebase. I have a suggestion for displaying the timers: (defun resize-window--notify-status ()...

oh also i updated the test matrix so if you rebase on master it should give a more modern array of emacsen to test against. I would like the tests...

oh and one other thing: you certainly deserve a spot as one of the authors now. So I'll invite you to add your name into the header of the file...