kafka-python Add connection_timeout_ms and reset the timeout counter more often

This PR complements #2386

Lacks tests

This change is

Aug 09 '23 05:08 petterroea

Let's get some tests going to characterize this better, and touch things up so it passes existing tests.

Aug 12 '23 00:08 wbarnha

@wbarnha I can write some tests on Monday if that is good for you

Aug 12 '23 08:08 petterroea

Should be good now!

Some unrelated tests fail from time to time on my machine due to Child thread died already, which doesn't seem to related.

I'm also a bit unsure as to why some random tests failed in the 015268d run

Aug 14 '23 06:08 petterroea

I see another PR(https://github.com/dpkp/kafka-python/pull/2381#partial-pull-merging) is struggling with the same CI errors, so I assume this PR is good. Is anything else required from my side?

Aug 23 '23 06:08 petterroea

I see another PR(#2381 (comment)) is struggling with the same CI errors, so I assume this PR is good. Is anything else required from my side?

I would appreciate if I could get feedback on my review. I'm mainly waiting to merge this until I have a proper release workflow ready. The original maintainer of the project has been absent for a while, and I'm trying to reestablish contact with him.

Aug 23 '23 11:08 wbarnha

I see another PR(#2381 (comment)) is struggling with the same CI errors, so I assume this PR is good. Is anything else required from my side?

I would appreciate if I could get feedback on my review. I'm mainly waiting to merge this until I have a proper release workflow ready. The original maintainer of the project has been absent for a while, and I'm trying to reestablish contact with him.

I see. I am unable to see any review, did you use reviewable?

Aug 30 '23 06:08 petterroea

Hello, is there any update?

Nov 22 '23 01:11 petterroea

I'm still around. Did you see my review in https://github.com/dpkp/kafka-python/pull/2388#discussion_r1294140798?

Nov 22 '23 01:11 wbarnha

@wbarnha Hey!

No, I cannot see any review. Neither on reviewable nor here i can se no code comments, and no typical "requested changes" message that usually follows a GitHub review. Am i missing something?

Your link does not properly work, it takes me to this PR, but it doesn't take me to a concrete comment. Is it hidden from people who aren't maintainers? Is it not yet submitted?

Attached for reference, what I see:

Nov 22 '23 02:11 petterroea

Weird, let me see what's going on.

Nov 22 '23 02:11 wbarnha

I forgot to submit... 🤦‍♂️

Nov 22 '23 02:11 wbarnha

It happens! Give me a few to re-familiarize myself and get you a proper reply

Nov 22 '23 02:11 petterroea

@wbarnha how 'bout this?

Nov 24 '23 08:11 petterroea

FYI: The plan is to include this in the v2.0.4/v2.1.0 release once we properly get the current status of the project sorted out.

Nov 26 '23 21:11 wbarnha

This PR will be merged in via https://github.com/wbarnha/kafka-python-ng/pull/132

Apr 03 '24 14:04 wbarnha