Formbuilder icon indicating copy to clipboard operation
Formbuilder copied to clipboard

Split up form_open and form_open_multipart

Open dfreerksen opened this issue 14 years ago • 2 comments

I know @stickgrinder is making some big changes right now and if he doesn't make this change then I can. But I thought it would be better to split form_open and form_open_multipart to make them different methods. The primary reason being 90% of the time form_open() will be used.

If you don't agree with this, maybe a different option would be to keep them in the same method but switch the $multipart and $params parameters being passed to the method. Most of the time I am going to be setting the form attributes before I make it a multipart form.

dfreerksen avatar May 05 '11 14:05 dfreerksen

yeah thats a valid point, especially since thats how the form helper handles it, i want to try to keep it as simular to form helper methods as i can as people will be accustomed to using that.

dperrymorrow avatar May 05 '11 14:05 dperrymorrow

I agree! I actually forgot to consider the multipart issue! I'll add ->make_multipart() method to FB_creator, obviously it will be automagically called if you include a file field! :)

stickgrinder avatar May 05 '11 14:05 stickgrinder