doximity
Allow higher Sidekiq versions in gemspec
When I tried to install Simplekiq on a project, I had an issue with resolving dependencies:
Resolving dependencies....
Bundler could not find compatible versions for gem "sidekiq":
In snapshot (Gemfile.lock):
sidekiq (= 6.3.1)
In Gemfile:
sidekiq-pro was resolved to 5.3.0, which depends on
sidekiq (>= 6.3.0)
simplekiq was resolved to 0.0.3, which depends on
sidekiq (~> 5.2.9)
Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.
The README says "ensure you have sidekiq-pro at version ~> 5.0.0 or higher", so I'm assuming that newer versions of Sidekiq are also supported. Is that right?
I saw #12 mentions being blocked on getting sidekiq-pro as a dependency, so no worries if this needs to wait or is changing shortly!
Hi @jeremysmithco ! Thanks so much for the interest. We have https://github.com/doximity/simplekiq/pull/19 in the works which will help a bit with the dependency specificity, but when I have some time to noodle on your request I'll see if I can tweak things further to be able to support your versions... I'll have to reassess/review the reasons for our version specifications first though. Am I correct in interpreting that you're trying to ideally use the following versions?:
- sidekiq 6.3.1
- sidekiq-pro ~> 5.0.0 (as in, you're okay with our specification of ~> 5.0.0 it's just the sidekiq version issue?)
If I'm not able to safely adjust the version requirements I'll open an issue to track the problem so you can follow that issue to see when it'll be compatible with your needs. Thanks again for your interest!
Hey @jcwilk, thanks for the response! Good to know about #19. 👍
The project I'm hoping to use Simplekiq on is currently running:
- sidekiq 6.3.1
- sidekiq-pro 5.3.0
I'm thinking a version specification of sidekiq-pro ~> 5.0.0 would mean I'd have to downgrade to the 5.0 minor release series, right? (I'm hoping not to do that.)
Let me know if there's something I can help with. And feel free to close this PR, if need be! I can always use my fork until support is officially added. Thanks to the team for open sourcing this! 🙌
@jeremysmithco yep I think you've got it right, and I agree that's not ideal. Thanks for the specifics, stay tuned!
@jeremysmithco hi, following up a million months later - v0.1.0 should cover you, let me know if any issues. We're ramping up for the 1.0 release but wanted to give you a heads up on that early version being available already. We're just waiting until we've got things 100% stable to declare the 1.0 victory as we have a few kinks we're working out in our sidekiq system WRT some unrelated gems not working perfectly with the newest version of sidekiq, but the new simplekiq behavior has not shown any indications of issues. Thanks for your patience and do let us know how it's working out for you if you ended up finding a use for it :heart:
Hey, thanks so much @jcwilk! Funny timing, I've been using this branch on a client project since mid-June and I was just upgrading to 0.1.0 this morning!
It's worked great so far, and makes comprehending workflows so much easier. 👍 I appreciate it!